allow patching with no mod loader

Lauriethefish / QuestPatcher

Generic il2cpp modding tool for Oculus Quest (1/2/3) apps.

zlib License

261 stars 393 forks source link

allow patching with no mod loader #186

Closed jakzo closed 3 days ago

jakzo commented 1 week ago

Did this because I just wanted to add hand tracking permission to an APK which already had a mod loader without adding a new one. In my case the game was Bonelab with MelonLoader (would be nice if LemonLoader was merged into QuestPatcher but that's a separate conversation...)

Lauriethefish commented 4 days ago

I'd be happy to merge this but please rename the branch!

jakzo commented 3 days ago

Ok, looks like there is a conflict so I'll fix it when I have time and open a new pr but curious what the problem is with using main on the fork?

Lauriethefish commented 3 days ago

The issue is that it makes it much more difficult for me to review it and make local changes, since I have to pull it to a branch with a different name to avoid inadvertently merging the PR, but then git doesn't allow one to set it as upstream so every time I want to push I have to specify HEAD:. It's just bad practice - any change should always have a branch properly named.

Thanks for fixing the conflict when you do. I'll close this for now.