LavaMoat / snow

Use Snow to finally secure your web app's same origin realms!
https://lavamoat.github.io/snow/demo/
MIT License
102 stars 9 forks source link

Detect trusted HTMLs more safely #102

Closed weizman closed 1 year ago

weizman commented 1 year ago

Attempt to fix issue #95.

The idea is to find a safer way to tell trusted HTMLs from nodes.

The safest way I could think of is to just overwrite the behaviour of createHTML so that when a trusted HTML is created, we store it aside.

Then, when trying to figure out if a provided object is not a node but a trusted HTML, we can simply look it up in the stash of trusted HTMLs we keep - that way we don't rely on any properties of the trusted HTML object itself, which makes this safe.

Unless there's a way to clone a trusted HTML instance.........?