search

Lavaburn / puppet-mikrotik

Puppet Module for managing Mikrotik Devices
Apache License 2.0
9 stars 2 forks source link

Add OpenVPN Server and Client support, Certificate upload and installation #3

Closed philomory closed 5 years ago

philomory commented 6 years ago

I've got a basic implementation of OpenVPN Server and Client creation, as well as uploading and registering certificates and associated keys (as well as other files). This is all working in our environment right now, but I'm sure some of my code could stand to be cleaned up or tweaked.

File and Certificate upload requires the gem 'net-scp' be installed on the device proxy alongside the 'mtik' gem, since the Mikrotik API doesn't really support uploading files.

philomory commented 5 years ago

Is there any interest in having this functionality? If there's any adjustments you'd like made to the pull request in order to be happy merging it, I'd be happy to discuss them.

Lavaburn commented 5 years ago

Can you merge this into a single commit (rebased on current master)? I'll gladly merge it if it does not break anything.

philomory commented 5 years ago

That's done, hopefully this is structured the way you like.

I have another branch with other new resources and small bugfixes, but unfortunately I wasn't very forward-thinking and did all that work on a single branch so it may take some time for me to un-entangle it into separate pull requests.

philomory commented 5 years ago

Sorry, I found a number of additional commits that should have been part of the squashed & rebased pull-request. I think all of the OpenVPN, Certificate and File-related functionality I've implemented is now included in the pull-request.

philomory commented 5 years ago

@Lavaburn Does this meet with your approval now?