Lavaeolous / PF1-StatBlock-Converter-Module

FoundryVTT Module to convert PF1 Statblocks into Foundry Actors (PC or NPC).
MIT License
14 stars 12 forks source link

Nonfunctional since V10 update #549

Closed Dntfdtrols closed 2 years ago

Dntfdtrols commented 2 years ago

Parses only up to statistics. Throws normal error codes if you take out the statistics part but stays on "parsing: base" if statistics are included. This mod is literally my favorite and I might just have to go back to roll20 without it. Please fix it <3

gregprater311 commented 2 years ago

Curious as to the future of this very useful module.

ElvesLie commented 2 years ago

I've been having this issue too. I updated Foundry and am desperately trying to work on my campaign but am now stuck with so much progress at a sudden halt. Can we expect an update any time soon? Thanks

Eagle0600 commented 2 years ago

As a temporary solution, you could download statblock-converter/scripts/sbcUtils.js from my commit (above) and place it in Documents/FoundryVTT/Data/modules/pf1-statblock-converter/scripts, overwriting the original file.

ElvesLie commented 2 years ago

For me the location was in C:\Users\%username%\AppData\Local\FoundryVTT\Data\modules\pf1-statblock-converter\scripts.

I've replaced the file but without any significant changes (I did try disabling every other module to test this as well).

As you can see with the image below, I am using your version, and for reference I'm using Version 10, Build 285 of Foundry.

FoundryPullRequest

Thanks for your help on this matter! :)

TheQuain commented 2 years ago

You can right-click the taskbar icon for foundry when it's open and select "Browse User Data" to get to it wherever it is installed.

I'm working on fixing this for myself, I've been out of coding for years and want to practice a little bit. So if nobody else posts a fix before I get it working reasonably I will. (non-item attacks and multiple class-level characters are importing borked still for me as of current)

Eagle0600 commented 2 years ago

@ElvesLie, can you please tell me which creature you are trying to import? Perhaps I can replicate your error and have a go at it myself

ElvesLie commented 2 years ago

I've been trying random ones like Recruit (warrior 1) from the NPC Codex for example.

I feel like there's a 50/50 chance I've missed a critical step here, but to my current knowledge, it should be working after implanting your fix. Thanks for taking the time to reach out!

ElvesLie commented 2 years ago

You can right-click the taskbar icon for foundry when it's open and select "Browse User Data" to get to it wherever it is installed.

I'm working on fixing this for myself, I've been out of coding for years and want to practice a little bit. So if nobody else posts a fix before I get it working reasonably I will. (non-item attacks and multiple class-level characters are importing borked still for me as of current)

I'm very rusty myself, haha. I tried having a little peek myself before giving up and just coming to GitHub for more answers. Yeah my Browse User Data takes me to the AppData/Local area, which is where I've put the .js in. C:\Users\%userdata%\AppData\Local\FoundryVTT\Data\modules\pf1-statblock-converter\scripts

I know that name has been changed to id and other various things, but kept looking in the wrong place to fix it. I'm tired and just too out of practice to bother too much into it anymore.

Eagle0600 commented 2 years ago

@ElvesLie Check that you are using build 0.82.1 of PF1 system. Try creating a new world with statblock converter as the only loaded module. Import using the following text exactly. If it doesn't work, reload and open up the DevTools (F12). Go to the console, right click, and clear console. Open the converter and try again. When it fails, copy the red text for me.

Recruit CR 1/3
Source NPC Codex pg. 266
XP 135
Dwarf warrior 1
N Medium humanoid (dwarf)
Init +0; Senses darkvision 60 ft.; Perception +1
Defense
AC 18, touch 10, flat-footed 18 (+6 armor, +2 shield)
hp 8 (1d10+3)
Fort +4, Ref +0, Will +0; +2 vs. poison, spells, and spell-like abilities
Defensive Abilities defensive training (+4 dodge bonus to AC vs. giants)
Offense
Speed 20 ft.
Melee dwarven waraxe +3 (1d10+1/×3) or dagger +2 (1d4+1/19–20)
Ranged light crossbow +1 (1d8/19–20)
Special Attacks +1 on attack rolls against goblinoid and orc humanoids
Tactics
During Combat The warrior prefers melee combat and working with other soldiers. He uses alchemist’s fire against targets resistant to weapon damage.
Statistics
Str 13, Dex 11, Con 14, Int 10, Wis 10, Cha 7
Base Atk +1; CMB +2; CMD 12 (16 vs. bull rush or trip)
Feats Weapon Focus (dwarven waraxe)
Skills Intimidate +2, Perception +1 (+3 to notice unusual stonework)
Languages Common, Dwarven
Combat Gear alchemist’s fire; Other Gear chainmail, heavy wooden shield, dagger, dwarven waraxe, light crossbow with 20 bolts, 12 gp
ElvesLie commented 2 years ago

@ElvesLie Check that you are using build 0.82.1 of PF1 system. Try creating a new world with statblock converter as the only loaded module. Import using the following text exactly. If it doesn't work, reload and open up the DevTools (F12). Go to the console, right click, and clear console. Open the converter and try again. When it fails, copy the red text for me.

Recruit CR 1/3
Source NPC Codex pg. 266
XP 135
Dwarf warrior 1
N Medium humanoid (dwarf)
Init +0; Senses darkvision 60 ft.; Perception +1
Defense
AC 18, touch 10, flat-footed 18 (+6 armor, +2 shield)
hp 8 (1d10+3)
Fort +4, Ref +0, Will +0; +2 vs. poison, spells, and spell-like abilities
Defensive Abilities defensive training (+4 dodge bonus to AC vs. giants)
Offense
Speed 20 ft.
Melee dwarven waraxe +3 (1d10+1/×3) or dagger +2 (1d4+1/19–20)
Ranged light crossbow +1 (1d8/19–20)
Special Attacks +1 on attack rolls against goblinoid and orc humanoids
Tactics
During Combat The warrior prefers melee combat and working with other soldiers. He uses alchemist’s fire against targets resistant to weapon damage.
Statistics
Str 13, Dex 11, Con 14, Int 10, Wis 10, Cha 7
Base Atk +1; CMB +2; CMD 12 (16 vs. bull rush or trip)
Feats Weapon Focus (dwarven waraxe)
Skills Intimidate +2, Perception +1 (+3 to notice unusual stonework)
Languages Common, Dwarven
Combat Gear alchemist’s fire; Other Gear chainmail, heavy wooden shield, dagger, dwarven waraxe, light crossbow with 20 bolts, 12 gp

That worked! Thanks for that!

However, I should point out that wasn't the only way to convert a statblock into an actor. If you open the statblock there's also a conversion button there too (which is the button I was referring to). But this is a fine work around for now. You're awesome!

Lavaeolous commented 2 years ago

Yeah, sbcs not compatible to v10 yet. I plan to work on it in the coming weeks, but have little time currently (and i fear i have to change alot as the data/document structure changed again with v10).

multiplenerdgasms commented 2 years ago

Yeah, sbcs not compatible to v10 yet. I plan to work on it in the coming weeks, but have little time currently (and i fear i have to change alot as the data/document structure changed again with v10).

Love your work, mate! Let us know if there is any way we can support you in the task.

Lavaeolous commented 2 years ago

findEntityInCompendium changed on the systemside. The issue is fixed in the v4.0.0 branch. Most of everything works now, but i still have to test spellcasters

gregprater311 commented 2 years ago

thanks

Lavaeolous commented 2 years ago

v4.0.0 is now released and should be compatible to v10 of Foundry