search

Lavaeolous / PF1-StatBlock-Converter-Module

FoundryVTT Module to convert PF1 Statblocks into Foundry Actors (PC or NPC).
MIT License
14 stars 12 forks source link

Racial modifier is incorrectly doubled up as ranks #600

Closed mkahvi closed 11 months ago

mkahvi commented 1 year ago

For example, Hobgoblin: https://www.aonprd.com/MonsterDisplay.aspx?ItemName=Hobgoblin
They have +4 racial modifier to stealth, no stated ranks. The imported sheet has 4 ranks in stealth in the end AND they have +4 racial modifier in the race.

Lavaeolous commented 1 year ago

I'm currently not doing anything with racial modifiers (see Changelog v3.1.1), as these are values that should already be known by the total and the changes in the race.

// Check, if the rawSkill contains "racial modifiers"
// And skip to the end of the array as we do not need these
if (rawSkill.search(/racial (?:modifier|bonus)/i) !== -1) {
    return
}

I'll have to investigate, but i think i currently do not check existing race items for skill changes, so these get ignored when calculating how many ranks need to be put into a skill. Which in turn leads to the buff needing to compensate at the end when everything is known.