Laverna / laverna

Laverna is a JavaScript note taking application with Markdown editor and encryption support. Consider it like open source alternative to Evernote.
https://laverna.cc/index.html
Mozilla Public License 2.0
9.2k stars 801 forks source link

[FIX] Rename jade to pug #870

Closed paradite closed 7 years ago

paradite commented 7 years ago

Hi, initially I cloned this repo because I wanted to fix a UI bug in the released version where the title for the note is not shown, and instead the word title is shown. Then I realized that this bug was already fixed in dev branch and dev branch is way ahead of master.

But I found another bug during the setup, that is caused by the renaming of jade into pug in the prismjs package since 1.8.2:

This bug causes the web app to throw error and stop working due to missing dependency:

Error: Cannot find module './prism-jade.min.js'.

Ideally the change should not affect this project because the version of the prismjs package is defined as 1.7.0 in package-lock.json, but somehow 1.7.0 in package-lock.json does not match package.json which is "prismjs": "^1.8.1". So when I did npm install, it fetches prismjs:1.8.4 and updates package-lock.json. Maybe you can regenerate the package-lock.json file? I've checked out package-lock.json in this PR.

FYI: npm's behavior regarding conflicting versions:

coveralls commented 7 years ago

Coverage Status

Coverage increased (+10.7%) to 94.905% when pulling 40973ad7198cd0478c700bdcbc880e761a32556d on paradite:dev into 32a569d2210d7e3ecc773de244bac9927867a23a on Laverna:dev.