search

Laverna / laverna

Laverna is a JavaScript note taking application with Markdown editor and encryption support. Consider it like open source alternative to Evernote.
https://laverna.cc/index.html
Mozilla Public License 2.0
9.2k stars 801 forks source link

New notes are trashed if hitting 'esc' #917

Open sylver opened 6 years ago

sylver commented 6 years ago

New notes are put in trash if during the edit 'esc' is hit and cancel at least once.

How to reproduce

Expected behavior

No matter how many times we can hit 'esc' (vim reflex...), the note should be saved in the right Notebook and not go in trash afterward.

morem0 commented 6 years ago

I experienced a similar behavior, but instead of moving note to trash, changes were not saved at all.

To reproduce, follow comments above.

daed commented 6 years ago

Did you guys try this in the release version or the dev branch version?

Because I literally just tried it in the dev branch and it looks like it's been fixed.

funilrys commented 6 years ago

@daed Most people are talking about the latest release as we distribute the last release and not git branches.

morem0 commented 6 years ago

@daed: To be honest, I didn't try it out on the developer version. Did you install it from source with bower and gulp? Because for me, everything went fine but after installation I tried to start laverna with gulp and nothing happened...

daed commented 6 years ago

I can replicate the issue on the release version (the electron bundled one). I might have a look at it to see if it's an easy fix, but I'd rather move the dev branch to something usable since it looks like a major rework of the old one.

@morem0, installing off the dev branch doesn't use bower, but you do have to install mongodb. Instructions are here: https://github.com/Laverna/laverna/tree/dev

daed commented 6 years ago

I have a PR submitted for this.