search

Laverna / laverna

Laverna is a JavaScript note taking application with Markdown editor and encryption support. Consider it like open source alternative to Evernote.
https://laverna.cc/index.html
Mozilla Public License 2.0
9.18k stars 801 forks source link

fix bug 917 #962

Closed daed closed 6 years ago

daed commented 6 years ago

See https://github.com/Laverna/laverna/issues/917 for backstory.

Boolean self.deleteData was set to true before the cancellation confirmation form was shown. Comments suggest that this would be set to false later if cancelled, but it didn't appear to properly cancel.

Changing self.deleteData to false instead causes clicking "Ok" to send the note to the trash (existing behavior, as expected), and cancel to not send the note to the trash if saved later (corrected behavior, as expected).

funilrys commented 6 years ago

@daed We should ignore master branch fix as the dev branch will overwrite everything but good catch ! @wwwredfish @wwebfor Please merge and publish a new release (of master) after merging !