LawnchairLauncher / lawnchair

No clever tagline needed.
https://lawnchair.app
Other
9.2k stars 1.2k forks source link

[BUG] adding support for app-provided monochrome/adaptive icons #3568

Open RustoMCSpit opened 1 year ago

RustoMCSpit commented 1 year ago

Describe the bug

if you set your icons to themed and switch to lawnicons and then switch back to system icons theyll stay as lawnicons, you cant get back regular monochrome system icons

Steps to reproduce

Steps to reproduce the behavior: 1) turn on themed icons 2) swap to lawnicons 3) swap back to system icons

Expected behavior

see regular system monochrome icons

Screenshots

No response

Device information

pixel 6a,

Additional context

No response

KTibow commented 1 year ago

pretty sure if you want to turn off themed icons, you need to turn off themed icons, not just change the icon pack

RustoMCSpit commented 1 year ago

pretty sure if you want to turn off themed icons, you need to turn off themed icons, not just change the icon pack

regardless of what pack i choose, the themed icons are the same; they are ONLY the lawnchair icon themes. i cant see 'systemicon' themed icons.

RustoMCSpit commented 1 year ago

https://github.com/thetwom/toc2/releases

download this app and turn on themed system icons, if it doesnt go monochrome the bug is confirmed as real because in all other launchers it does. for me, it isnt themed despite having a systemicon theming

KTibow commented 1 year ago

I don't know what "system monochrome" you're talking about - AFAIK you need Lawnicons to use themed icons.

RustoMCSpit commented 1 year ago

I don't know what "system monochrome" you're talking about - AFAIK you need Lawnicons to use themed icons.

you dont need lawnicons to use themed icons, turn lawnchair off for a second and go to the regular launcher and turn on themed icons

KTibow commented 1 year ago

You're assuming everyone has themed icons built into their system launcher. Most people don't.

RustoMCSpit commented 1 year ago

You're assuming everyone has themed icons built into their system launcher. Most people don't.

right, well find a launcher that lets https://github.com/thetwom/toc2/releases turn into its monochrome form and youll understand what im talkimg about

RustoMCSpit commented 1 year ago

if you want a screenshot i can give yu one

KTibow commented 1 year ago

Sure, give a screenshot of the problem. It seems odd given that the icon pack you use for one launcher is affecting Lawnchair.

RustoMCSpit commented 1 year ago

Sure, give a screenshot of the problem. It seems odd given that the icon pack you use for one launcher is affecting Lawnchair.

_20230811_230716

RustoMCSpit commented 1 year ago

thats what the monochrome theme of the app looks like normally in any other launcher with system icons, lawnchair launcher is unable to do that. lawnchair launchers monochrome mode only supports its own icpn pack

KTibow commented 1 year ago

Can you please edit your issue title and contents to clarify that this is about adding support for app-provided monochrome/adaptive icons?

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

KTibow commented 10 months ago

still relevant

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

KTibow commented 5 months ago

nopedy dopedy

abdallahmehiz commented 1 month ago

Is this feature feasible? If not, why? Lack of launcher privileges? Lack of system APIs? Or something different?