search

LawnchairLauncher / lawnchair

No clever tagline needed.
https://lawnchair.app
Other
9.16k stars 1.2k forks source link

We should check accessibility permission and use it first. #3833

Open Goooler opened 9 months ago

Goooler commented 9 months ago

One more thing, we should check accessibility permission and use it first, fallback to root access if there is no accessibility granted.

Originally posted by @Goooler in https://github.com/LawnchairLauncher/lawnchair/issues/3799#issuecomment-1844282201

MrSluffy commented 9 months ago

I think it's better first root and seems to working fine, and why it's label bug?

Goooler commented 9 months ago

Root is a more sensitive permission than accessibility, we should avoid using it as much as possible.

Goooler commented 9 months ago

For some users like me, they already granted accessibility for sleeping, but after upgrading to Lawnchair 13, they still see the Root request, that's unnecessary.

MrSluffy commented 9 months ago

I see, that make sense

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.