LawnchairLauncher / lawnchair

No clever tagline needed.
https://lawnchair.app
Other
9.51k stars 1.23k forks source link

Wrong icon for Dialer (LineageOS, GrapheneOS) #4281

Open x9136 opened 7 months ago

x9136 commented 7 months ago

Describe the bug

Since #2555 is closed without a solution, we return to the issue.

Incorrect icon is assigned to the Dialer from LineageOS and GrapheneOS for unknown reasons. If you change the icon manually, it does not change either. Works only when "Home Screen & App drawer" selected in the "Themed Icons" settings.

Detailed discussion https://github.com/LawnchairLauncher/lawnicons/issues/1728

Steps to reproduce

Install LineageOS or GrapheneOS → Install Lawnchair and Lawnicons → Select Lawnicons in Lawnchair and try "Off" or "Home screen" in the "Themed Icons" settings.

Expected behavior

Dialer has the correct icon for any selection in the "Themed Icons" setting.

Screenshots

image

Device information

Device: - OS: LineageOS, GrapheneOS App version: 14 Beta 2

Additional context

No response

alpha4041 commented 7 months ago

it does edit the icon but not the themed one

E8Ib commented 7 months ago

Maybe it's because Contacts and Dailer are both com.android.contacts.

<!-- Contacts -->
<item component="ComponentInfo{com.android.contacts/com.android.contacts.activities.PeopleActivity}" drawable="contacts"/>

<!-- Phone -->
<item component="ComponentInfo{com.android.contacts/com.android.contacts.activities.TwelveKeyDialer}" drawable="phone"/>
x9136 commented 7 months ago

Maybe it's because Contacts and Dailer are both com.android.contacts.

I do not know which OS you are talking about, but you are right about this OS. I'll take that into account. However, this is not the only issue.

CaptainColdAJ commented 2 days ago

The same is happening for MIUI devices. Instead of phone app, the contacts app is showing in the favourites tray in the home screen, just because both share the same apk name,. Could you help with this issue and get a possible fix.