search

LawnchairLauncher / lawnchair

No clever tagline needed.
https://lawnchair.app
Other
8.9k stars 1.17k forks source link

No indication of what number UI slider refers to #4548

Open tgex0 opened 2 weeks ago

tgex0 commented 2 weeks ago

Describe the bug

In 'Drawer search -> Web suggestions', the slider "Maximum number of suggestions in search results" shows no numbers so the user does not know what number each slider setting refers to.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to 'Drawer search'
  2. Select 'Search algorithm -> Global search'
  3. Click 'Web suggestions'
  4. Enable 'Web suggestions' in pop-up
  5. See "Maximum number of suggestions in search results'... slider has no corresponding numbers (perhaps due to string being too long?)

Expected behavior

Slider should show its corresponding setting number to the right-hand side of the label.

Screenshots

Screenshot_2024-07-06-10-39-09-995_app lawnchair

Device information

Additional context

No response

tgex0 commented 2 weeks ago

Just checked... works fine with a shorter string (numbers appear to the right of the string as expected).

(Similar problem to https://github.com/LawnchairLauncher/lawnchair/issues/4547 but different string.)

However, my phone uses a European/EEA stock ROM with English (United Kingdom) language/locale but I noticed that Lawnchair uses the strings from the values-en-rCA/strings.xml (Canadian English) file. If this is not intentional, please let me know and I'll open a new bug report. Thanks.

sarojpanda44 commented 2 days ago

It's visible for other options like Apps & Shortcuts, People and Files. There also UI string are long

sarojpanda44 commented 2 days ago

If the UI string jumps to second line then it's messed up. I think it's fixable by giving fixed width to the number field on the right side.