LawnchairLauncher / lawnchair

No clever tagline needed.
https://lawnchair.app
Other
9.49k stars 1.23k forks source link

[BUG] Unable to set custom icon for Work apps #4559

Open yoyosamo opened 4 months ago

yoyosamo commented 4 months ago

Describe the bug

Whilst setting things up after downloading the Lawnchair 14 Beta 2, I noticed a small issue with trying to set a custom icon for apps in the Work profile on my device. For apps that exist in both the Personal and Work profiles, the custom icon is always being applied to the Personal app and the Work app cannot be changed. For apps that only exist in the Work profile, trying to set a custom icon causes Lawnchair to crash.

Steps to reproduce

Steps to reproduce the behavior:

  1. Add an app from the Work profile to the Home Screen
    • Work profile created using Shelter
  2. Open the Customize menu and select a custom icon
  3. If the app exists in both the Personal and Work profiles, the custom icon is applied only to the Personal version of the app
  4. If the app only exists in the Work profile, Lawnchair crashes before the Icon Picker can be loaded

Expected behavior

Selecting a custom icon should function correctly and identically for apps in the Work profile A custom icon should be applied to each 'version' of an app independently

Screenshots

https://github.com/user-attachments/assets/1fba8086-a324-47b0-890c-7d92b562bdac

Device information

Additional context

No response

gsture commented 3 months ago

I can confirm this issue. Selecting an icon in the work profile crashes the launcher.

App version: 14 beta 3 Device: Pixel 8 OS: GrapheneOS 14 (AP2A.240805.005)

Steinhagen commented 2 months ago

I can confirm this issue is reproducible on the latest Play Store version.

Device: Fairphone 4 OS: FP4.TP2I.C.0121.20240626

splattergamesextended commented 2 months ago

I can also confirm this. Apps that were cloned from the main profile via Shelter for example, are not affected. Just those that were installed directly in the work profile.