LawnchairLauncher / lawnchair

No clever tagline needed.
https://lawnchair.app
Other
9.45k stars 1.23k forks source link

[BUG] Gesture navigation gets locked in one orientation until a launcher restart happens [A10] #4642

Open NekoMimiOfficial opened 3 months ago

NekoMimiOfficial commented 3 months ago

Describe the bug

After further testing my previous statement which includes that gesture nav doesn't work in landscape was false and it appears that gesture nav works fine in both orientations however it seems that its fixed to the orientation of when the launcher starts so if you change the orientation and restart the launcher it will work in the new orientation but you'll still have to restart it if you change the orientation again

It probably needs an event listener on when the orientation changes to adjust the recents screen

Steps to reproduce

Steps to reproduce the behavior:

  1. Start launchair
  2. Switch orientation
  3. Notice the recents screen won't open
  4. Restart launchair while staying at the new orientation
  5. It now works but you'll have to do the same everytime you change orientation

Expected behavior

Works without restart

Screenshots

No response

Device information

Additional context

No response

NekoMimiOfficial commented 2 days ago

This is still an issue in the latest build (pre 15)

s0m3th1ng-r4nd0m commented 2 days ago

Going from landscape to portrait mode makes the bottom swipe gesture unusable while the side gestures still work. Quick fix for that is making your device go into landscape mode and then portrait again. It gets it working for me at least.

NekoMimiOfficial commented 2 days ago

That's not entirely true, gesture navigations won't respond if I change the orientation until I revert back to the previous one If my phone was in portrait and I switched to landscape gesture navigation won't work no matter how many times I switch the orientation unless I either restart lawnchair or go back to portrait, additionally you can notice the recents screen not switching orientations sometimes if you open it then switch the orientation which will keep it at the old one, seems to be an issue with the recents activity not updating it's orientation

s0m3th1ng-r4nd0m commented 2 days ago

That's not entirely true, gesture navigations won't respond if I change the orientation until I revert back to the previous one If my phone was in portrait and I switched to landscape gesture navigation won't work no matter how many times I switch the orientation unless I either restart lawnchair or go back to portrait,

Are you using Quickswitch? I don't have this issue on my side at all. I change my device's orientation like 20 times per day and i have not had this happen to me once. The only noticeable thing on my side that happens is bottom swipe gesture not working sometimes.

additionally you can notice the recents screen not switching orientations sometimes if you open it then switch the orientation which will keep it at the old one, seems to be an issue with the recents activity not updating it's orientation

True true, i just checked and it does happen but I've never encountered it on my own. Might be because i hate recents screen in landscape mode so i just subconsciously switch to portrait before i open my recents.

NekoMimiOfficial commented 2 days ago

Yes I'm using quick switch 3.3.8 as version 4 doesn't work for me, what version of QS are you using?

s0m3th1ng-r4nd0m commented 1 day ago

Yes I'm using quick switch 3.3.8 as version 4 doesn't work for me, what version of QS are you using?

4.0.3 is the module version and the app version is 3.3.1

s0m3th1ng-r4nd0m commented 1 day ago

I'm on Android 12 stock rom (GO edition if that matters) using Lawnchair 14 Beta 3.

NekoMimiOfficial commented 1 day ago

I updated both module and app to your versions, reset the module then selected laenchair as the recents provider after a reboot it's exactly the same, nothing changed unfortunately

s0m3th1ng-r4nd0m commented 1 day ago

I updated both module and app to your versions, reset the module then selected laenchair as the recents provider after a reboot it's exactly the same, nothing changed unfortunately

Well, i don't know anymore. This is weird. Could it be an OS version issue? I'm not a developer so i don't know anymore.