LawnchairLauncher / lawnicons

Adds themed icons to Lawnchair.
Apache License 2.0
1.4k stars 464 forks source link

[DISCUSSION] Lawnicons not applying dark-theme icon pack to other launchers #1154

Open lettersforword365 opened 1 year ago

lettersforword365 commented 1 year ago

About this discussion

I've just updated to the latest version (2.0.0) on my Android 11 (OxygenOS 11) device.

The update means icons can be applied to launchers beside Lawnchair.

I read that:

Lawnicons will have a dark or white background depending on the system theme

My device has a systemwide dark theme which supports all apps with this feature. However, I am unable to view dark icons regardless of the system theme's state (both dark and light).

Applying Lawnicons to launchers (except Lawnchair) shows light-themed icons:

Lawnicons applied to other launcher (systemwide dark theme)

I also noticed that the About tab of the Lawnicons app shows the app icon in a light background when the systemwide dark theme is enabled and vice versa:

Lawnicons About tab (systemwide dark theme)

Lawnicons About tab (systemwide light theme)

Are the icons (when applied to other launchers) also expected to be black and white for devices that don't natively support material you (Android 11 and below), or does the app have support for wallpaper-based colouring on all devices (like Lawnchair)? I am unable to produce dark-themed icons, so I am unable to tell myself.

dhirenvasnani commented 1 year ago

I am also experiencing same issue, MIUI 12.5 Android 11.

ereinstein commented 1 year ago

The behaviour I observed might be related.

I have a Pixel 7 Pro with GrapheneOS and Lawnchair.

When I set an application's icon manually, it does not adapt to changes between light and dark themes, e.g. when I set the light themed icon while my system theme is light, it remains light even if my system switches to a dark theme afterwards and vice versa.

When I press and hold on the icon in order to change it via "Customize", the icon shown in the pop-up window respects the system theme regardless of the icon theme on the home screen.

Everything works perfectly for icons that are set automatically because the app itself has an icon in the icon pack.

E-D-W-I-N commented 1 year ago

Same here. Pixel 6 Pro with Lawnchair.

Here's my wallpaper
Here's my system setted accent color (kinda yellowish)
And here's Lawnchair's accent color settings (again, I choose system yellowish color, not "wallpaper" greenish one)
Here I have two icons - left one is set automatically and it's color perfectly matches my system color. Icon on the right was set manually and it's color is "wallpaper" greenish one from Lawnchair settings on the screenshot above, not the system one
If I change my display theme to white this icons will look like this

So now it's obvious that manually set icons are broken and they follow color that Lawnchair chooses as Wallpaper color and not the system one.

If I change my wallpaper automatically set icon will match system wallpaper color again, and manual icon will remain same

P.S. Sorry for a bunch of screenshots guys

QKIvan commented 1 year ago

The same in Android13,OnePlus 8 Pro,Nameless Launcher

SuperDragonXD commented 1 year ago

The core issue in the first post is fixed in the latest version (2.1). The colors for pre-A12 devices was reversed, and now fixed in that version.

As for the themed icons not properly changing colors (A12+ only), try restarting Lawnchair, change the icon pack (to trigger icon cache reset), re-apply the icons.

E-D-W-I-N commented 1 year ago

As for the themed icons not properly changing colors (A12+ only), try restarting Lawnchair, change the icon pack (to trigger icon cache reset), re-apply the icons.

Yeah, It works if you change the icon pack a few times and restart Lawnchair, but still it's really bad UX. I hope there's a way to clear cache automatically on wallpaper or system color change