Problem with icons applying

Vijorich commented 1 year ago

About this discussion

Why do some icons not change even though they are in the icon pack and all links are correct?

https://user-images.githubusercontent.com/88296320/210801719-5fb48acb-d24d-4138-a2c9-66834c0516e2.mp4

Vijorich commented 1 year ago

Steam (com.valvesoftware.android.steam.community)
Xtra (com.github.andreyasadchy.xtra)
Goodline (info.goodline.mobile2)
FixPrice (ru.bestprice.fixprice)
Grill one (ru.geo.ppmobile.grillone)
Eapteka (ru.getpharma.eapteka)
Paysphere (ru.nskes.paysphera)
SGK (ru.sibgenco.general)
Riseup VPN (se.leap.riseupvpn)
Mind Tracker (com.fedosov.mindtracker) These icons do not apply properly

jacksonwelsh commented 1 year ago

+1, 1password 8 as well. com.1password.android

naveenccmsd commented 1 year ago

@Vijorich Can you share the app component details for the above apps to verify?

you can follow below guid to get it. https://github.com/LawnchairLauncher/lawnicons/blob/develop/CONTRIBUTING.md#using-3rd-party-apps

or below

https://user-images.githubusercontent.com/7315975/214953769-0b5bdc7f-61fa-4c76-a2b6-bc2b38ff2af5.mp4

jacksonwelsh commented 1 year ago

For 1password:

<appfilter>

    <!-- 1Password -->
    <item component="ComponentInfo{com.onepassword.android/com.onepassword.android.app.StartActivity}" drawable="1password"/>

</appfilter>

naveenccmsd commented 1 year ago

@jacksonwelsh , Thank you . I have added link for 1password.

https://github.com/LawnchairLauncher/lawnicons/pull/1002

Vijorich commented 1 year ago

@Vijorich Can you share the app component details for the above apps to verify?

you can follow below guid to get it. https://github.com/LawnchairLauncher/lawnicons/blob/develop/CONTRIBUTING.md#using-3rd-party-apps

or below

https://user-images.githubusercontent.com/7315975/214953769-0b5bdc7f-61fa-4c76-a2b6-bc2b38ff2af5.mp4

https://paste.crdroid.net/l4CdeH

https://user-images.githubusercontent.com/88296320/215277431-f765adc8-2cff-4ec4-aa8d-9840c97b51eb.mp4

naveenccmsd commented 1 year ago

@Vijorich I undersnad you were facing issue with icon request app , unfortuanitly it was not owned by lawncher team, we can't fix the issue , without appcomponent details from your mobile we can't fix the icon mapping issue.

Can you try with any other apps and extract the app componenet details ? it should be something like below

Alernativy try the below app and select iconsrequest option

https://github.com/naveenccmsd/Ayan/releases/download/1.2.2/Ayan_iconpack_v1.2.2.apk or candybar dev in from playstore

Vijorich commented 1 year ago

@naveenccmsd Steam (com.valvesoftware.android.steam.community/com.valvesoftware.android.steam.community.MainActivity) Steam.svg Goodline (info.goodline.mobile2/info.goodline.mobile2.MainActivity) goodline.svg FixPrice (ru.bestprice.fixprice/ru.bestprice.fixprice.application.root.MainActivity) FixPrice.svg Grill one (ru.geo.ppmobile.grillone/ru.geo.ppmobile.grillone.MainActivity) grillone.svg Eapteka (ru.getpharma.eapteka/ru.getpharma.eapteka.mainscreen.bottom_navigation.MainActivityWithBottomBar) eapteka.svg Paysphere (ru.nskes.paysphera/ru.nskes.paysphera.presentation_v2.screen.activity.main_activity.MainActivity) paysphera.svg SGK (ru.sibgenco.general/ru.sibgenco.general.ui.activity.HomeActivity) skg.svg Riseup VPN (se.leap.riseupvpn/se.leap.bitmaskclient.base.MainActivity) riseup_vpn.svg Mind Tracker (com.fedosov.mindtracker/com.fedosov.mindtracker.MainActivity) mindtracker.svg RuStore (ru.vk.store/ru.vk.store.app.MainActivity) rustore.svg Pyaterochka (ru.pyaterochka.app.browser/ru.pyaterochka.app.browser.BrowserActivity) pyaterochka.svg Sber mega market (ru.goods.marketplace/ru.goods.marketplace.SingleActivity) sber_mega_market.svg

Chefski commented 1 year ago

@Vijorich could you check if all the icons are working as intended now with the latest debug file?

Vijorich commented 1 year ago

@Chefski Screenshot_20230313-045131_Sushi Launcher.png

3/12

daywalk3r666 commented 1 year ago

Screenshot_20230313-072335_Lawnchair (Debug)

6/9

I will check if the activities are right and the right drawable are linked

daywalk3r666 commented 1 year ago

Screenshot_20230313-081947_Lawnchair (Debug) Test it with this version of lawnchair https://github.com/LawnchairLauncher/lawnchair/commit/44da9e2 If my pull request won't work for you. Try to delete app data, maybe deleting cache is enough?