search

Lawo / ember-plus

Ember+ control protocol - Slick and free for all!
https://github.com/Lawo/ember-plus/wiki
Boost Software License 1.0
111 stars 42 forks source link

rxBufferSize in libember_slim/Source/__sample_provider.c #62

Open DHDaudio-support opened 7 years ago

DHDaudio-support commented 7 years ago

For those who are using libember_slim as is (with the sample code), there might be an issue for providers when receiving multi-paket messages with the maximum possible payload of 1024 bytes (see also https://github.com/Lawo/ember-plus-sharp/issues/42).

The rxBufferSize in in https://github.com/Lawo/ember-plus/blob/master/libember_slim/Source/__sample_provider.c is set to 1024 - but as far as we see it should also be minimum 1290 in order to handle Ember+ packets with maximum payload correctly.

In comparison see that the rxBufferSize in the https://github.com/Lawo/ember-plus/blob/master/libember_slim/Source/__sample_consumer.c is set to 1290.

KimonHoffmann commented 7 years ago

Good spot, thank you! Could you submit a pull request correcting this?