Closed warvariuc closed 9 years ago
I don't quite understand what you mean. These lines
if ws:
self.server.pool.track(ws)
will be reached in the old and new implementations only if there were no exceptions in the first 3 lines, because of this:
except:
raise
Damn. I somehow read finally rather than else on the try/except. You are right.
Maybe there should be some logic using finally
but I am not aware of it.
I think I need to spend some time trying to identify the key issues with error handlings and related cleanups.
Hello,
I'm not quite sure it was a useless try/except clause. As it stands, in your code the ws object may never removed from the pool. Is that expected?