Lawouach / WebSocket-for-Python

WebSocket client and server library for Python 2 and 3 as well as PyPy (ws4py 0.5.1)
https://ws4py.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
1.12k stars 288 forks source link

Change threaded client test to test ssl socket #213

Closed awelkie closed 7 years ago

awelkie commented 7 years ago

This change tests the bug that was fixed in pull request #212 . The call to self.assertTrue(c._th.is_alive()) would fail before the changes in that pull request.

I decided to just modify the existing test. Let me know if you'd prefer a new separate test instead.

tito commented 7 years ago

Yes, make it as a new test (at least one with and without _is_secure). As both are testing differents paths.

awelkie commented 7 years ago

Done

tito commented 7 years ago

You're awesome, thanks you!