search

Lay3rLabs / avs-toolkit

MIT License
5 stars 4 forks source link

Ensure that Wasmatic does not stop when non-valid addresses are passed #95

Open evanorti opened 4 days ago

evanorti commented 4 days ago

What happens now: If a user uploads a new WASM contract and specifies a random address (not the correct contract address), things break.

What should happen: if a user uploads a new WASM contract and specifies a random address, an error should be displayed and things shouldn't break.

This should be tested against a random string and an invalid address (not the correct contract) to ensure that the dev is alerted of an error without breaking things.

macovedj commented 3 days ago

This isn't quite right.

For both test and local, I just deployed some wasm components using "foobar" as a task address as well as a task address that differed from a valid task address by one character.

Both cases result in a success (should definitely error for arbitrary strings, can also check separately if a valid address form actually exists or not and supply a different error in that case). However, neither of these actions break anything. Wasmatic continues to function properly for apps deployed with valid task address in both cases.