search

LayerTwo-Labs / bip300301_enforcer

CUSF software enforcing BIP300 and BIP301 rules.
1 stars 4 forks source link

Implement generate_blocks RPC #41

Closed nchashch closed 2 weeks ago

nchashch commented 2 weeks ago

Closes #37

Ash-L2L commented 2 weeks ago

LGTM, approved. There are a few FIXMEs in here, is this ready to merge?

nchashch commented 2 weeks ago

I tested the RPC implementation locally, it does successfully generate blocks.

nchashch commented 2 weeks ago

LGTM, approved. There are a few FIXMEs in here, is this ready to merge?

Yes.

        // FIXME: Remove `optional` from the `blocks` parameter in the proto file.

is for the cusf_sidechain_proto repository.

and it would make sense to fix

            // FIXME: Make this code more sane.

in a separate refactor PR. It is more important to get the whole system working first, before making the code pretty.