LayerTwo-Labs / bip300301_enforcer

CUSF software enforcing BIP300 and BIP301 rules.
1 stars 4 forks source link

server: comments, error response for get_ctip, input validation #7

Closed torkelrogstad closed 1 month ago

torkelrogstad commented 1 month ago
  1. Clarify what the GetCtip endpoint does through a comment in the proto file
  2. Proper error handling in GetCtip:
    1. Return an error if the sidechain is not found
    2. Make the sidechain number request field optional. This is to differentiate not passing a number from passing 0. The former is invalid, and we indicate this with a proper error message
  3. Update the README with more context for devving