Open torkelrogstad opened 1 week ago
We're using sidechain_number and sidechain_id apparently nilly-willy.
sidechain_number
sidechain_id
I've found sidechain_number in different requests in validator.proto:
validator.proto
GetCoinbasePSBTRequest
AckSidechain
ProposeBundle
GetCtipRequest
GetSidechainProposalsResponse.SidechainProposal
GetSidechainsResponse.SidechainInfo
Whereas sidechain_id is found in:
GetBlockInfoRequest
GetBmmHStarCommitmentRequest
GetTwoWayPegDataRequest
SubscribeEventsRequest
wallet.proto
BroadcastWithdrawalBundleRequest
CreateBmmCriticalDataTransactionRequest
CreateDepositTransactionRequest
I think it'd be a good idea to be consistent in what we're using. Personally I think I prefer sidechain_id.
We're using
sidechain_number
andsidechain_id
apparently nilly-willy.I've found
sidechain_number
in different requests invalidator.proto
:GetCoinbasePSBTRequest
AckSidechain
ProposeBundle
GetCtipRequest
GetSidechainProposalsResponse.SidechainProposal
GetSidechainsResponse.SidechainInfo
Whereas
sidechain_id
is found in:validator.proto
GetBlockInfoRequest
GetBmmHStarCommitmentRequest
GetTwoWayPegDataRequest
SubscribeEventsRequest
wallet.proto
BroadcastWithdrawalBundleRequest
CreateBmmCriticalDataTransactionRequest
CreateDepositTransactionRequest
I think it'd be a good idea to be consistent in what we're using. Personally I think I prefer
sidechain_id
.