search

LayerTwo-Labs / cusf_sidechain_proto

gRPC protocol definitions for a CUSF BIP300/BIP301 sidechain.
1 stars 2 forks source link

Inconsistent names for sidechain IDs #10

Open torkelrogstad opened 1 week ago

torkelrogstad commented 1 week ago

We're using sidechain_number and sidechain_id apparently nilly-willy.

I've found sidechain_number in different requests in validator.proto:

  1. GetCoinbasePSBTRequest
  2. AckSidechain
  3. ProposeBundle
  4. GetCtipRequest
  5. GetSidechainProposalsResponse.SidechainProposal
  6. GetSidechainsResponse.SidechainInfo

Whereas sidechain_id is found in:

  1. validator.proto
    1. GetBlockInfoRequest
    2. GetBmmHStarCommitmentRequest
    3. GetTwoWayPegDataRequest
    4. SubscribeEventsRequest
  2. wallet.proto
    1. BroadcastWithdrawalBundleRequest
    2. CreateBmmCriticalDataTransactionRequest
    3. CreateDepositTransactionRequest

I think it'd be a good idea to be consistent in what we're using. Personally I think I prefer sidechain_id.