search

LayerTwo-Labs / sidesail

A work-in-progress sidechain UI.
MIT License
6 stars 4 forks source link

drivechain-server/Justfile: extract features/tag to vars #234

Closed arnemolland closed 6 days ago

arnemolland commented 1 week ago

As per https://github.com/LayerTwo-Labs/sidesail/pull/231#discussion_r1754779760 I forgot to include this change in #231

torkelrogstad commented 1 week ago

I actually ended up just removing the install-bdk-cli target, as that would install bdk-cli to a location we don't use. IMO it's fine to leave that out - do you want it in?

arnemolland commented 1 week ago

I actually ended up just removing the install-bdk-cli target, as that would install bdk-cli to a location we don't use. IMO it's fine to leave that out - do you want it in?

Makes sense, I don't need it in. Should we still use variables then or does it become needlessly verbose?

torkelrogstad commented 6 days ago

I think I'll just close this for now, and if we end up updating the values at a later time we can extract to a var.