Add test_maxInts - Githubissues

LayerXcom / verified-vyper-contracts

FVyper: A collection of useful Vyper contracts developed with formal methods

Apache License 2.0

55 stars 15 forks source link

Add test_maxInts #48

Closed yudetamago closed 5 years ago

yudetamago commented 5 years ago

modifications

remove checking wei balances
remove depositing MAX_UINT256 hack ( https://github.com/ethereum/vyper/blob/97ed5fec89947d41fd91f5190c4478ffcadbb9fb/tests/examples/tokens/ERC20_solidity_compatible/test/erc20_tests_1.py#L174-L178 ) because that problem is fixed now ( https://github.com/ethereum/vyper/issues/653 ).

remarks

Transferring MAX_UINT256 + 1 tokens causes web3.exceptions.ValidationError ( https://github.com/LayerXcom/verified-vyper-contracts/pull/48/files#diff-eb9eb23418a279d00cc78d9b52f5b8c6R123 ) , not eth_tester.exceptions.ValidationError

nrryuya commented 5 years ago

LGTM

yudetamago commented 5 years ago

ok to merge?