LayerXcom / verified-vyper-contracts

FVyper: A collection of useful Vyper contracts developed with formal methods

Apache License 2.0

55 stars 15 forks source link

Initial PR #74

Closed hskang9 closed 5 years ago

hskang9 commented 5 years ago

What I did

resolve #73

I will extend this to have:

solve easy answers(e.g. 2,3,5,7)
Resolve Fermat liars if they exist

Cute Animal Picture

nrryuya commented 5 years ago

@hskang9 Thank you! A few comments.

Could you rebase to the latest master branch and create a new PR? This inlined version is WIP and I think it'd be better to have a new directory and file contracts/prime/isPrime.vy because this contract can be used as stand-alone.
Tests are always necessary ;) Please add tests at tests/prime/test_isPrime.py.

nrryuya commented 5 years ago

@hskang9 About tests, I'll prepare BigInt.vy which can be used by isPrime.vy in #79

hskang9 commented 5 years ago

Thank you! @nrryuya now that I have Big integer operations in separate file, I can focus on the tester. I will create WIP to master branch based on the comments received 👍

hskang9 commented 5 years ago

Closing this for new PR

nrryuya commented 5 years ago

@hskang9

79 is still WIP so it's OK to wait for my work or to prepare only test cases (without actually executing them) ;)

hskang9 commented 5 years ago

I will put TODO in comment to remove big integer operations after BigInt.vy is developed.

hskang9 commented 5 years ago

This PR is now moved to #81