search

LayerXcom / zero-chain

A privacy-preserving blockchain on Substrate
https://layerxcom.github.io/zerochain-book/
GNU General Public License v3.0
260 stars 42 forks source link

Compiled file in repository #156

Closed kination closed 4 years ago

kination commented 4 years ago

Hello~first in project. Nice to meet you. When project builded, seems compiled file is indicated as changed file in git repository.

modified:    runtime/wasm/target/wasm32-unknown-unknown/release/zerochain_runtime_wasm.compact.wasm

Would this needed to be removed?

osuketh commented 4 years ago

Hi. It doesn't need to be removed. Something wrong with it?

kination commented 4 years ago

@osuketh oh, no. Just because modified file always occurs after build. If there is some reason to keep this in repository, it is fine. But seems better to ignore this file...

osuketh commented 4 years ago

Ah, it would be better. I'll fix it. Thanks for pointing out.

ashWhiteHat commented 4 years ago

Hi @osuketh This phenomenon occurred on my environment too and the reasoning is that git tracks the wasm file in runtime/wasm/target directory. I fixed it with this PR

kination commented 4 years ago

@osuketh @NoCtrlZ Seems okay to close~