search

LayerXcom / zero-chain

A privacy-preserving blockchain on Substrate
https://layerxcom.github.io/zerochain-book/
GNU General Public License v3.0
260 stars 42 forks source link

Removed some warnings #158

Closed ashWhiteHat closed 4 years ago

ashWhiteHat commented 4 years ago

■First commit Just remove the unnecessary semicolon.

■Second commit The into_iter() return the reference currently but this function will stop returning reference because of upcoming breaking change following issue so it won't be able to use *. Replacing with iter(), it keeps returning reference. https://github.com/rust-lang/rust/issues/66145

■Third commit We can use ? operator instead of try!. The RFC about this is following. https://rust-lang.github.io/rfcs/1859-try-trait.html#desugaring-and-the-try-trait

■Fourth commit The alloc crate is stable since Version 1.36.0 (2019-07-04) release so we don't have to require the attribute.

osuketh commented 4 years ago

Thanks for this PR. LGTM