search

LayeredStudio / whoiser

🌍 Easy to use WHOIS info for domains, TLDs and IPs
MIT License
202 stars 29 forks source link

Add "encoding" option #105

Open tpimh opened 1 year ago

tpimh commented 1 year ago
Q A
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #104
License MIT

How I use it is, if the response can contain special characters in an 8 bit encoding, I set "encoding" to "binary". This is similar to how node-whois module does it. It can be considered a new feature, but I don't think it's significant enough.

AndreiIgna commented 1 year ago

hey @tpimh thanks for adding this, it looks like a helpful option. It will be merged and included in the next release.

Can you add the option in the readme as well please? Maybe others would need this option too, and is easier to see it there. And possibly a test, if you know which whois server returns data in this way?

Thanks

tpimh commented 1 year ago

Sure, I will be happy to add the option to readme and write a test for the server that I am using it with.

AndreiIgna commented 11 months ago

@tpimh the encoding option is set only for whoisQuery function, so it can't be used for a domain or tld query

tpimh commented 11 months ago

Yes, that's correct. That is something I have noticed when writing documentation, so I will be changing this and updating this pull request.