Umlauts not working for .de domains

LayeredStudio / whoiser

🌍 Easy to use WHOIS info for domains, TLDs and IPs

MIT License

215 stars 32 forks source link

Umlauts not working for .de domains #93

Closed lukasbableck closed 1 year ago

lukasbableck commented 1 year ago

Version(s) affected: 1.14.0

Description
If you use an umlaut in a .de domain, you get "Domain Status": [ "invalid" ], This does work on other tlds and should also work on .de.

How to reproduce
whoiser.domain("testä.de")

jonathansampson commented 1 year ago

The issue here is with the punycode step, occurring immediately within the whoisDomain function. Sending Unicode instead of ascii to whois.denic.de resolves the issue.

AndreiIgna commented 1 year ago

Thanks for the fix @jonathansampson, this is now merged and released in v1.15