Layers-of-Railways / Railway

Official repository of the Create Railways mod for Minecraft
GNU Lesser General Public License v3.0
86 stars 54 forks source link

Hard dependency on create version will cause Create: Steam 'n' Rails to not launch on any create update #451

Open solonovamax opened 5 months ago

solonovamax commented 5 months ago

Describe the Bug

Currently, the dependency for create is specified as "create": "${create_fabric_version}". This will cause the mod to not launch for any minor updates to create. Alternatively, you should do

"create": ">=${create_fabric_version}"

and, you should also ensure that the version injected into there is simply 0.5.1 (or perhaps 0.5.1-f at most), and does not include the build number.

This is similar to #404, and prevents issues in the future.

Reproduction Steps

N/A

Expected Result

N/A

Screenshots and Videos

N/A

Crash Report or Log

N/A

Operating System

Arch Linux 6.8.4-zen1-1-zen

Mod Version

1.6.0

Create Mod Version

0.5.1f

Minecraft Version

1.20.1

ModLoader and Version

N/A

Other Mods

N/A

Additional Context

N/A

IThundxr commented 5 months ago

annoyingly this issue is harder then it should be, we need to hard dep on specific patches but for that we need to check just 0.5.1-*, however fabric won't do that since that's not valid semver, i'm looking at making a pr to floader to allow regex in dependencies which should make this easier to fix

solonovamax commented 5 months ago

annoyingly this issue is harder then it should be, we need to hard dep on specific patches but for that we need to check just 0.5.1-*, however fabric won't do that since that's not valid semver, i'm looking at making a pr to floader to allow regex in dependencies which should make this easier to fix

ah, afaik it was valid semver and would be treated as a prerelease part

IThundxr commented 3 months ago

this will be fixed once a release with create fabric's stubMod is released (it'll allow mods to depend on a version string that is the same between sub patches on fabric

IThundxr commented 1 month ago

There's unfortunately no nice way to do this, if we use a wildcard dependency then people will be able to use it with older or newer versions that it doesn't work with, floader doesn't load JiJ mods in dev so the stubmod wouldn't work, regex dependencies are off the table and changing create versioning is aswell