Wrong capitalization in the German prefixes

[hsiktas]

Hi,

this is only a cosmetic grammar issue but because it is not covered by the current capitalization options, this might count as a bug instead of a German translation error. 🤔

In German we begin all nouns with a capital letter and this applies to the word "Viertel" from the German prefixes: https://github.com/LayoutXML/Twelveish/blob/a3a13054b849e878b8219bb00fa1f394d2d13f1a/app/src/main/res/values/strings.xml#L330-L342

Here is a nice overview of how that prefix is used in the right way: https://www.dict.cc/?s=Viertel+vor

I don't know if this should be a new option for the capitalization menu of if this should be an exception for all existing capitalization options but in its current state it just looks wrong for German speakers. 😏

[LayoutXML]

Hi @hsiktas ,

I see. To fix it I should rewrite lots of code. Do people also capitalize nouns when writting informally?

At the momemnt there are 5 capitalization options:

1. All words title case - nouns are capitalized ✔️
2. All uppercase - nouns are capitalized ✔️
3. All lowercase - nouns are not cpaitalized ❌
4. First word title case - nouns are not always capitalized ❌
5. First word in every line title case - nouns are not always capitalized ❌

I will see what I can do.

[augustuen]

I see. To fix it I should rewrite lots of code. Do people also capitalize nouns when writting informally?

To my knowledge the capitalisation of nouns in German is quite alike to capitalisation of the first word in English, meaning that there's no situation where you can not do it (according to the rules), but it's left out in casual messages. I don't feel like this is such a situation however, although I think the all uppercase and all lowercase options should be maintained.

As for implementation it seems that it could easily be solved by capitalising the nouns in strings.xml, and adding a toLowerCase on the output of WordClockTask.capitalise2(). I've got a fix ready to be pull-requested.

[msix81]

I love the watch face, however the wrong German capitalization looks quite unprofessional. @augustuen if you have a fix ready, why don't you raise a PR?

[augustuen]

I love the watch face, however the wrong German capitalization looks quite unprofessional. @augustuen if you have a fix ready, why don't you raise a PR?

I'm not quite sure why I didn't at the time. Maybe I couldn't separate it from the other modifications I'd done and promtly forgot about it? IDK, that's living with ADD I guess.

I did find my fix though, will submit it in a little while when I've sorted my Gradle issues. The way I understand it though, Viertel should be capitalized, while times (like eins, zwölf, etc) shouldn't? Would love your input @msix81 @hsiktas. My german is pretty good but I've never encountered this issue before.

[msix81]

Viertel should be capitalized, while times (like eins, zwölf, etc) shouldn't?

Exactly - "Viertel" is a noun (engl. "quarter"), whereas numbers and other words like "halb" or "oder so" are not. First word should be capitalized as well, but that can be achieved by the current options as far as I understand.