search

LayoutXML / Twelveish

🕛 Twelveish - Android Wear/Wear OS Watch Face
https://play.google.com/store/apps/details?id=com.layoutxml.twelveish
GNU General Public License v3.0
43 stars 19 forks source link

Twelveish 10 #22

Open augustuen opened 3 years ago

augustuen commented 3 years ago

Fixes #10 by adding missing capitalization of nouns in the german translation. Also does toLowerCase() before the output of capitalise2().

msix81 commented 3 years ago

Capitalization looks fine, words like "halb" or any number should remain in lower case (as is).

To be 100% correct, the first word should be capitalized as well - I had already forked the repo to do this but later realized that using the existing option should work just fine as well.

augustuen commented 3 years ago

To be 100% correct, the first word should be capitalized as well - I had already forked the repo to do this but later realized that using the existing option should work just fine as well.

Yup, unless the user specifically chooses all lowercase or all uppercase, the first word will always have the first letter capitalized. That was already built-in and so didn't need to be amended in this PR.

There is still an issue with all worlds title case though, where certain words (like "nach" and "so") aren't capitalized since they're not recognized as separate words.