chore(breaking): add EIGENDA_PROXY prefix to memstore flags

Layr-Labs / eigenda-proxy

EigenDA sidecar proxy server used for communication between rollup software and EigenDA.

MIT License

14 stars 20 forks source link

chore(breaking): add EIGENDA_PROXY prefix to memstore flags #121

Closed samlaf closed 2 weeks ago

samlaf commented 2 weeks ago

Needed for consistency with all other flags. For some reason MEMSTORE flags are the only ones without the EIGENDA_PROXY flag.

Breaking

This is a breaking change for anyone who was running the proxy using the env var flags. They will need to add the prefix so we should communicate this change.

bxue-l2 commented 2 weeks ago

We can make it non-breaking by having both ENV available.

samlaf commented 2 weeks ago

would you be able to also update the .env.example files? like

https://github.com/Layr-Labs/eigenda-proxy/blob/ae7a0da530ec89a8432f3d3d6d65af95da46ee02/.env.example.holesky#L65

Done: bfe39a6

bxue-l2 commented 2 weeks ago

LGTM - breaking the env namespace should be fine given customers should never use them in a production setting

good point