search

Layr-Labs / eigenda-proxy

EigenDA sidecar proxy server used for communication between rollup software and EigenDA.
MIT License
14 stars 20 forks source link

Potential bug: submitting oversized blob results in internal server error #127

Closed samlaf closed 1 week ago

samlaf commented 2 weeks ago

Running the TestProxyServerWithOversizedBlob e2e test, and it passes but the logs look like:

...
/Users/samlaf/devel/eigenlayer/da-integrations/eigenda-proxy/e2e/server_test.go:144: Setting input data on proxy server...
t=2024-09-17T14:23:00-0700 lvl=info msg=request role=eigenda_proxy method=POST url="/put/?commitment_mode=simple"
t=2024-09-17T14:23:00-0700 lvl=debug msg="Storing data to EigenDA backend" role=eigenda_proxy
t=2024-09-17T14:23:00-0700 lvl=error msg="internal server error" role=eigenda_proxy err="put request failed with commitment [] (commitment mode simple): blob is larger than max blob size: blob length 170000000, max blob size 16777216"
t=2024-09-17T14:23:00-0700 lvl=error msg="put request failed with commitment [] (commitment mode simple): blob is larger than max blob size: blob length 170000000, max blob size 16777216" role=eigenda_proxy
--- PASS: TestProxyServerWithOversizedBlob (3.93s)

(running on main might see different error msgs since I was running this on the samlaf--devex-improvements branch with more expressive error msgs, but the essential idea remains the same)

Issue

don't think we should be logging an internal server error for an error that sounds to me (?) like it should be a 400?