Since we merged the PR that fixed the confDepth=-1 bug, now confDepth is always a non-negative number, so the conf checker is broken. Running make run-memstore-server results in this CRIT:
CRIT [09-19|21:18:50.564] Application failed role=eigenda_proxy message="eth confirmation depth is set for certificate verification, but Eth RPC or SvcManagerAddr is not set"
I changed the checks a bit arbitrarily... not super sure if it's correct, @epociask please take a good look. When using the memstore we don't need ethRPC or svsManagerAddr do we?
Tests are failing, waiting for correct semantic before changing them. Also removed the -v from make test because that prints too much garbage and is impossible to find the actual error when a test fails.
samlaf
commented
1 month ago
Since we merged the PR that fixed the
confDepth=-1bug, now confDepth is always a non-negative number, so the conf checker is broken. Runningmake run-memstore-serverresults in this CRIT:I changed the checks a bit arbitrarily... not super sure if it's correct, @epociask please take a good look. When using the memstore we don't need ethRPC or svsManagerAddr do we?
Tests are failing, waiting for correct semantic before changing them. Also removed the -v from
make testbecause that prints too much garbage and is impossible to find the actual error when a test fails.