Update internal data structures

Layr-Labs / eigenda

Secure, high-throughput, and decentralized Data Availability

https://www.eigenlayer.xyz/

Other

220 stars 168 forks source link

Update internal data structures #732

Open mooselumph opened 1 month ago

mooselumph commented 1 month ago

Why are these changes needed?

Internal renaming of data structures in support of planned interface updates and unified blob lookup scheme.

Checks

[ ] I've made sure the lint is passing in this PR.
[ ] I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
Testing Strategy
- [ ] Unit tests
- [ ] Integration tests
- [ ] This PR is not tested :(

ian-shim commented 1 week ago

Does the way we ended up building this into a breaking v2 release vs. just interface update in v1 change the approach in this PR? For example, we don't need the concept of blob cert and nodes keep signing the batch header hash in v1.

mooselumph commented 1 week ago

Does the way we ended up building this into a breaking v2 release vs. just interface update in v1 change the approach in this PR? For example, we don't need the concept of blob cert and nodes keep signing the batch header hash in v1.

As we build V2, I think it will be useful to transform the internal data structures to the V2 format as much as possible. Do you have an alternative approach?

ian-shim commented 6 days ago

Does the way we ended up building this into a breaking v2 release vs. just interface update in v1 change the approach in this PR? For example, we don't need the concept of blob cert and nodes keep signing the batch header hash in v1.

As we build V2, I think it will be useful to transform the internal data structures to the V2 format as much as possible. Do you have an alternative approach?

I agree in principle, but the blob header or blob certificate in v1 (change proposed in this PR) don't match that of v2, right? How do we ensure that these two core structs interchangeable for both v1 & v2?