Layr-Labs / hello-world-avs

Hello World AVS
MIT License
63 stars 58 forks source link

bug: script `npm run deploy:hello-world` not working #87

Closed technophile-04 closed 1 week ago

technophile-04 commented 1 week ago

Description :

I tried following the initial steps from README npm run start:anvil, npm run deploy:core this scripts ran nicely but when I run npm run deploy:hello-world I get this :

Error message : ```shell ❯ npm run deploy:hello-world > hello-world-avs@1.0.0 deploy:hello-world > cd contracts && forge script script/HelloWorldDeployer.s.sol --rpc-url http://localhost:8545 --broadcast [⠒] Compiling... No files changed, compilation skipped Traces: [6486236] → new HelloWorldDeployer@0x9f7cF1d1F558E57ef88a59ac3D47214eF25B6A06 └─ ← [Return] 32280 bytes of code [680667] HelloWorldDeployer::setUp() ├─ [0] VM::envUint("PRIVATE_KEY") [staticcall] │ └─ ← [Return] ├─ [0] VM::rememberKey() │ └─ ← [Return] Deployer: [0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266] ├─ [0] VM::label(Deployer: [0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266], "Deployer") │ └─ ← [Return] ├─ [0] VM::toString(31337 [3.133e4]) [staticcall] │ └─ ← [Return] "31337" ├─ [0] VM::exists("deployments/core/31337.json") │ └─ ← [Return] true ├─ [0] VM::readFile("deployments/core/31337.json") [staticcall] │ └─ ← [Return] ├─ [0] VM::parseJsonAddress("", ".addresses.strategyManager") [staticcall] │ └─ ← [Return] 0x0165878A594ca255338adfa4d48449f69242Eb8F ├─ [0] VM::parseJsonAddress("", ".addresses.eigenPodManager") [staticcall] │ └─ ← [Return] 0x2279B7A0a67DB372996a5FaB50D91eAA73d2eBe6 ├─ [0] VM::parseJsonAddress("", ".addresses.delegation") [staticcall] │ └─ ← [Return] 0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0 ├─ [0] VM::parseJsonAddress("", ".addresses.avsDirectory") [staticcall] │ └─ ← [Return] 0xDc64a140Aa3E981100a9becA4E685f962f0cF6C9 ├─ [495280] → new ERC20Mock@0x5aAdFB43eF8dAF45DD80F4676345b7676f1D70e3 │ └─ ← [Return] 2448 bytes of code ├─ [0] 0x0000000000000000000000000000000000000000::deployNewStrategy(ERC20Mock: [0x5aAdFB43eF8dAF45DD80F4676345b7676f1D70e3]) │ └─ ← [Stop] └─ ← [Revert] EvmError: Revert Error: script failed: ```

Seeing at stack traces it seems it error's out same place #57

Version of foundryup : ```shell foundryup: installed - forge 0.2.0 (2044fae 2024-10-23T00:21:24.886258000Z) foundryup: installed - cast 0.2.0 (2044fae 2024-10-23T00:21:24.915695000Z) foundryup: installed - anvil 0.2.0 (2044fae 2024-10-23T00:21:24.855153000Z) foundryup: installed - chisel 0.2.0 (2044fae 2024-10-23T00:21:24.865531000Z) ```

Thanks !!

stevennevins commented 1 week ago

Addressed in https://github.com/Layr-Labs/hello-world-avs/pull/88 lmk if you have any other issues!