search

Layr-Labs / incredible-squaring-avs

Basic repo demoing a simple AVS middleware with full eigenlayer integration
Other
159 stars 101 forks source link

Update eigenlayer-middleware to dev head #46

Closed samlaf closed 2 months ago

samlaf commented 2 months ago

Current eigenlayer-middleware is on a very old commit, which doesn't even use the AVSDirectory. This PR is made to fix this.

Update: this was a much bigger change than I expected. Had to update the sdk to latest version, which had some changes in some types and services, which needed to be propagated here.

docker-compose test is failing, but that's fine, I need to fix that separately. We can merge without it.

wawrzek commented 2 months ago

@samlaf if I'm correct, this PR does not bring middleware to the HEAD of the dev branch, but to the commit 48e0aecae3f778356a5009f912ade946b285fe9b, which is pointed at the tag: v0.1.2-holesky-init-deployment and branch:testnet-holesky. And it misses following commits:

59ebd32 (HEAD -> dev, origin/dev, origin/HEAD) Use uint32 for number of ejected operators (#232)
0328639 feat: return ops ejected (#228)
6454c05 feat: allowlist mapping (#226)
f224cf9 chore: bump forge-std and remove ds-test dependency (#227)
c29cf07 feat: automated ejector (#146)
5204b23 (origin/mainnet) Add mainnet table to docs (#224)
74efe8e (tag: v0.1.3-mainnet-m2+pragma-change, origin/m2-mainnet) Merge branch 'dev' of https://github.com/Layr-Labs/eigenlayer-middleware into m2-mainnet
fb313de chore: less restrictive pragma (#216)
a2b1847 (tag: v0.1.3-mainnet-m2) chore: update core submodule
dc9d013 Delete unused deploy scripts (#219)
715a702 chore: switch library license from BSL to MIT (#217)
6a7a385 docs: finally things are reasonable again (#214)
eae9114 feat: ecdsa basic registry (#194)
samlaf commented 2 months ago

@samlaf if I'm correct, this PR does not bring middleware to the HEAD of the dev branch, but to the commit 48e0aecae3f778356a5009f912ade946b285fe9b, which is pointed at the tag: v0.1.2-holesky-init-deployment and branch:testnet-holesky. And it misses following commits:

59ebd32 (HEAD -> dev, origin/dev, origin/HEAD) Use uint32 for number of ejected operators (#232)
0328639 feat: return ops ejected (#228)
6454c05 feat: allowlist mapping (#226)
f224cf9 chore: bump forge-std and remove ds-test dependency (#227)
c29cf07 feat: automated ejector (#146)
5204b23 (origin/mainnet) Add mainnet table to docs (#224)
74efe8e (tag: v0.1.3-mainnet-m2+pragma-change, origin/m2-mainnet) Merge branch 'dev' of https://github.com/Layr-Labs/eigenlayer-middleware into m2-mainnet
fb313de chore: less restrictive pragma (#216)
a2b1847 (tag: v0.1.3-mainnet-m2) chore: update core submodule
dc9d013 Delete unused deploy scripts (#219)
715a702 chore: switch library license from BSL to MIT (#217)
6a7a385 docs: finally things are reasonable again (#214)
eae9114 feat: ecdsa basic registry (#194)

No it's pointing at commit deebd4b (which was head of dev when I made the changes). If you look at the commit history in this PR, I originally changed it to point to M2-mainnet for precisely the reasons that you and @zees-dev are pointing out, but then realized that I need some changes on dev head for the deploy scripts to work :\

image

Apologize for the mess... Constructive feedback is always welcomed.