LazeMSS / OctoPrint-UICustomizer

UI Customizer for octoprint
164 stars 18 forks source link

Plugin icon for the OctoPrint-WifiStatus Plugin misaligned? #15

Closed devsfan1830 closed 3 years ago

devsfan1830 commented 3 years ago

Seems to be similar to an older solved bug. The icon for this plugin is centered rather than being aligned with the other icons. No biggie but if you could push a fix whenever, or let me know how to do so myself I'd appreciate it. Otherwise just want to say this is a fantastic plugin. Gives the web interface a much needed refresh. Untitled

OS: Windows 10 Browser: Edge (Chromium based)

LazeMSS commented 3 years ago

This is probally fixed in the next release - you can try and pull the latest commit if you dont want to wait for the release. I dont have wifi on my RPI so dont know how it behaves when connected. I tried faking it a bit and seems to be working. When tested please close this.

LazeMSS commented 3 years ago

Should be now fixed - please update and test :)

devsfan1830 commented 3 years ago

Unfortunately the update didnt fix it. Tried flushing my browser history. Disabling and re-enabling both plugins. Its really no biggie. Its not a vital plugin anyways. I just used it to double check my connection once and just left it enabled. No other plugin i use place icons in that bar so I was just letting you know in case others might. Im happy to close this issue for now if you want.

LazeMSS commented 3 years ago

@devsfan1830 can you try and disabling all other 3rdparty plugins you have installed: This is a list of plugins I can confirm it works with on my setups

devsfan1830 commented 3 years ago

My currently installed plugins:

I have disabled everything. Then reenabled UI Customizer only, reloaded server. Then enabled WifiStatus. WifiStatus icon still ends up dead center.

LazeMSS commented 3 years ago

I have just uninstalled everything aswell - this is my list of 3rd party:

And built-in/bundled:

devsfan1830 commented 3 years ago

Might figured it out. Oversight on my part. I didnt see the "Center Top Bar Icons" option. Turned that off and refreshed and its all good now. Sorry! I did however observe an odd behavior with the "Preview" option turned on. Every time i toggled the center option it dumped the contents of that wifi status drop down into the top bar. Fortunately a refresh clears its away so its not a permanent thing. Here a video in case you're curious. https://www.youtube.com/watch?v=FldWvQk8Q8U But as far as this issue is concerned I'll go ahead and close it. Thanks!

LazeMSS commented 3 years ago

Might figured it out. Oversight on my part. I didnt see the "Center Top Bar Icons" option. Turned that off and refreshed and its all good now. Sorry! I did however observe an odd behavior with the "Preview" option turned on. Every time i toggled the center option it dumped the contents of that wifi status drop down into the top bar. Fortunately a refresh clears its away so its not a permanent thing. Here a video in case you're curious. https://www.youtube.com/watch?v=FldWvQk8Q8U But as far as this issue is concerned I'll go ahead and close it. Thanks!

DOHHH

And I found the other you found and fixed that in the next release - I would really recommend you turn on "Improve mobile/responsive" - this also fixes it until then :)