search

LazeMSS / OctoPrint-UICustomizer

UI Customizer for octoprint
165 stars 18 forks source link

webcam problems in ver 0.1.8.7 #234

Closed CBDesignS closed 2 years ago

CBDesignS commented 2 years ago

Description

**ENTER DESCRIPTION HERE Describe your problem?

Webcam preview in right part of screen just says Loading webcam until it gives up. Cam pictures are live if the option to display in control menu is unticked as it should be but if the box is ticked to hide then it never comes back in the other preview window.. This is brand new to this release of 0.1.8.7

cam1 cam2 cam3

What is the problem? Can you recreate it? Did you try disabling plugins? Did you remember to update the subject?**

Plugins installed

nius] v2.2.8

UI Customizer settings

Software versions

Browser

LazeMSS commented 2 years ago

@CBDesignS and it still works?

CBDesignS commented 2 years ago

@CBDesignS and it still works?

yea. still going strong.

This is what I have left to install.. system is now rebooting after installing bed visualizer

Bed Visualizer[bedlevelvisualizer] v1.1.1
BLTouch Plugin[BLTouch] v0.3.4
Camera Settings[camerasettings] v0.3.1
FileManager[filemanager] v0.1.6
Firmware Updater[firmwareupdater] v1.13.1
LightsOut[lightsout] v0.1.2
M117 Speech Synthesis[M117SpeechSynthesis] v0.5.3
Navbar Temperature Plugin[navbartemp] v0.14
OneDrive Backup[onedrive_backup] v1.0.1
PrintTimeGenius Plugin[PrintTimeGenius] v2.2.8
clarkiej commented 2 years ago

@clarkiej and @ddpt83 your problems are probally related to PrintJobHistory creating a duplicate of the main webcam id: OllisGit/OctoPrint-PrintJobHistory#194

After disabling PrintJobHistory floating webcam still works fine but FullScreenWebcam when you click on full screen does not work still. THis is teh same result with or without PrintJobHistory enabled

LazeMSS commented 2 years ago

@clarkiej and @ddpt83 your problems are probally related to PrintJobHistory creating a duplicate of the main webcam id: OllisGit/OctoPrint-PrintJobHistory#194

After disabling PrintJobHistory floating webcam still works fine but FullScreenWebcam when you click on full screen does not work still. THis is teh same result with or without PrintJobHistory enabled

So when having the webcam "zoom" set to fullscreen the webcam does not work where? Sorry but I have a lot of bug reports im trying to figure out 🙈

clarkiej commented 2 years ago

With PrintJobHistory enabled or disabled, the FloatingWebcam option works fine. You can move the window around when you click on the zoom icon in the top right corner. If you select FullScreenWebcam, the webcam shows, but when you click on teh zoom icon in teh top right corner, the webcam view vanishes and does not reappear.

Sorry for all teh comments as we know you are trying to identify teh issue.

LazeMSS commented 2 years ago

With PrintJobHistory enabled or disabled, the FloatingWebcam option works fine. You can move the window around when you click on the zoom icon in the top right corner. If you select FullScreenWebcam, the webcam shows, but when you click on teh zoom icon in teh top right corner, the webcam view vanishes and does not reappear.

Sorry for all teh comments as we know you are trying to identify teh issue.

Same options and plugins as posted here: https://github.com/LazeMSS/OctoPrint-UICustomizer/issues/234#issuecomment-1053486556

I can't recreate that - I have a fix for most of the stuff we have found so far

CBDesignS commented 2 years ago

@LazeMSS Another day and another session trying to freeze the stream

everything is still working as it should and the list is getting smaller.

BLTouch Plugin[BLTouch] v0.3.4 Camera Settings[camerasettings] v0.3.1 FileManager[filemanager] v0.1.6 Firmware Updater[firmwareupdater] v1.13.1 LightsOut[lightsout] v0.1.2 Navbar Temperature Plugin[navbartemp] v0.14 PrintTimeGenius Plugin[PrintTimeGenius] v2.2.8

from looking at the list of plugings left to install Lightsout, BLtouch & firmware updater I would say will be ok but the rest all would seem to indicate they interact with the octo gui / ui so could it be

Camera Settings[camerasettings] v0.3.1 FileManager[filemanager] v0.1.6 Navbar Temperature Plugin[navbartemp] v0.14 PrintTimeGenius Plugin[PrintTimeGenius] v2.2.8

If and I hope it is a big if these all reinstall and the stream still works as it should the only other thing I can think could be.. before your UIC plugin made life easy to skin and arrange the oct window I had a heavily modded ui using the good old hacks by using f12 dev mode to find and change settings and maybe even tho the relevant plugins were removed maybe some settings were left in a config or some other file and that is causing the problems. this sprung to mind because my other printer shows the same problems and I cheated when I set octo on its pi, I just used a backup from the old machine (pre built and ready to go) and only required minimal setup time to get me printing.

Because this is a clean from scratch setup whatever file or setting that may have caused this will not exist so uic is working correctly as it should .

this was just a though that passed thru my foggy mind lastnight Sirhc

LazeMSS commented 2 years ago

I have an upcomming release that basically tries to remove any broken dom created by plugins - there are sadly a bunch of plugins that makes a copy/reuses the unique id of the webcam. The way the webcam works in this latest version of UI Customizer is by "moving" the webcam around instead of creating another stream which is bloating both the browser and the backends.

CBDesignS commented 2 years ago

down to the last 4 plugins....

Navbar Temperature Plugin[navbartemp] v0.14

the above plugin has not caused a stream freeze but it is causing random weird things. selecting the octo settings wrench on the taskbar sometimes opens the window but compressed down to half a window size. Could this be conflicting with your UIC plugin @LazeMSS

CBDesignS commented 2 years ago

I have an upcomming release that basically tries to remove any broken dom created by plugins - there are sadly a bunch of plugins that makes a copy/reuses the unique id of the webcam. The way the webcam works in this latest version of UI Customizer is by "moving" the webcam around instead of creating another stream which is bloating both the browser and the backends.

I still have a printer & octo setup that still freezes the stream, if you want your upcomming release tested gimme a shout, I have nothing to loose if I will have to end up starting from scratch reinstalling octo.

CBDesignS commented 2 years ago

@LazeMSS

Edit >>> NO Plugins left to install as I have just installed the last one (camera settings) . All installed and busy testing the final print to see if the stream will freeze but so far its still running sweet....

A clean installed octo with exactly the same plugins is running great so it looks as tho some of the plugins are causing problems but in my case they were not causing the stream freeze problem (unless it starts for me a little later down the line).

so it could be back to the other thoughs of old settings/corrupt dom data etc from the themify days as the likley cause of the stream freezing. I know most users of octo are like most users of every other electronic device, they see an app or plugin or are told about one and they have to go install it, mess about with it unknowingly changing things, then remove it or just leave it installed but not using it and a little later on things start to go wrong and because there has been that much done on the system no one will even know where to start trying to fix it.. ( I was in IT for 30 years and have seen it day in and out with boot looping computers and phone apps that refuse to start)..

LazeMSS commented 2 years ago

I will try and make a branch for testing this ASAP

LazeMSS commented 2 years ago

Try installing the webcam test branch by using: https://github.com/LazeMSS/OctoPrint-UICustomizer/archive/refs/heads/webcamprobs.zip

Guide: https://plugins.octoprint.org/help/installation/

CBDesignS commented 2 years ago

your patch in action..

cam20

before the patch (on this setup) the webcam froze or was missing and today it was missing untill I applied your patch and the webcam popped back up so. will full reboot and see how it goes.. Fingers crossed @LazeMSS

p.s there was an update for pi utils or something and that failed with an error in a red warning box.. once I applid this patch and rebooted, it then updated rpi utils correctly.. I think your patch has cleaned up my system and it seems to be running great. NO stream FREEZING so far.

clarkiej commented 2 years ago

Patch has been applied.With the patch both floating and fullscreen webcam appear to work. On startup after applying the patch the message regarding PrettyGcode still popped up but I have your modified version running without incident.

Webcam enabled in Dashboard and Webcam mode set to Fullscreen image Triggering FullScreen works fine: image

When set to Overlayfloating Mode Triggering also works without incident: image

The webcam image also loaded immediately on connecting to OctoPrint as well when previously there was a lag and a spinning wheel before loading roughly half the time.

Outstanding response from you sir and much appreciated. Will fire up a print and monitor teh response and let you know if there is any issues while running for a period of time.

Update: Ran off a 45min print with no issues with freezing or hanging .Then ran off a 5 hour print and saw no issues.

LazeMSS commented 2 years ago

Thanks for all the feedback!

regarding the "notice/warning" about other plugins - its just there so I can remeber and easier "turn down" bug reports - and maybe nudge the other developers to fix their bugs ;)

LazeMSS commented 2 years ago

Should be fixed in https://github.com/LazeMSS/OctoPrint-UICustomizer/releases/tag/0.1.8.9 if not then please reopen this issue.