LazeMSS / OctoPrint-UICustomizer

UI Customizer for octoprint
165 stars 18 forks source link

[BUG] Main Tab Icons - Unable to Change color #245

Closed Ragnar123456 closed 2 years ago

Ragnar123456 commented 2 years ago

Description

Have tried several different times to change the color of the main tab icons using the included function. When I click on a color in the color picker, the icon in the popup does change color. However, when I click on the "X" to close the popup the icon on the main tab screen does change to the new color. If I go ahead and save anyway, the main tab icons do not have the color selected in the popup.

I have tried disabling all user installed plugins (except UI Customizer), but the same result continues.

Have also tried it with Firefox 98.0.2 (64-bit) with he same result.

Edit 1: Figured out how to get the color attached to the icon in the main tab. You have to select the color from the color picker first. The icons will then be the selected color. You then click on the colored icon and it is saved as the correct icon and color on the main tab.window.

However, even though the color is shown on the main tab window, when you save and exit UI Customizer, the colorized icons are not shown on the OctoPrint main screen.

Edit 2: After playing around with CSS in the advanced tab of UI Customizer, it would appear that the CSS attribute "!important" needs to be added to override a theme's colors.


Plugins installed

UI Customizer settings

Software versions

Browser

LazeMSS commented 2 years ago

I will look ASAP

LazeMSS commented 2 years ago

@Ragnar123456 which theme is overwriting the color icons - the color is set on the icon so the important should not be needed unless a theme is overwriting it

LazeMSS commented 2 years ago

Did a bit of improvement to the logic of the UI...

Ragnar123456 commented 2 years ago

I am currently using the Discorded theme. I just went through testing all of the themes. All respect the icon colors except Discorded and Red Night.

LazeMSS commented 2 years ago

Thanks will check

LazeMSS commented 2 years ago

Fixed in: https://github.com/LazeMSS/OctoPrint-UICustomizerThemes/releases/tag/0.2.9.6