LazeMSS / OctoPrint-UICustomizer

UI Customizer for octoprint
165 stars 18 forks source link

[Bug] Webcam display in right column is doubled. #250

Closed Ompapamowmow closed 1 year ago

Ompapamowmow commented 2 years ago

double_webcam

Description

After initial boot, when I change tabs, a second webcam view opens up right under the original in the right column. When I double click it, it opens the expanded pop-up view which is also doubled. When I double click again to get it to minimize it goes back to normal with only 1 webcam image. After that, it works normally for quite some time, but doubles again every once in a while. I have not yet pinpointed a specific action or circumstance that causes it to double.


Plugins installed

UI Customizer settings

Software versions

Browser

LazeMSS commented 2 years ago

Could you try disabling the PrettyGCode plugin

LazeMSS commented 2 years ago

Hopefully this is also fixed in the next update but please try disabling PrettyGCode and Octolapse to check if its something conflicting from them,

LazeMSS commented 2 years ago

Should be fixed in https://github.com/LazeMSS/OctoPrint-UICustomizer/releases/tag/0.1.9.0

Please reopen and comment if not working as expected.

MATV0 commented 2 years ago

Hi, I'm completely new to Github. Made this account to say that I've got exactly the same problem with the double webcams, and I'm using your 0.1.9.0. Sorry, I don't know how to reopen the above

LazeMSS commented 2 years ago

Hi, I'm completely new to Github. Made this account to say that I've got exactly the same problem with the double webcams, and I'm using your 0.1.9.0. Sorry, I don't know how to reopen the above

What other plugins do you have installed?

MATV0 commented 2 years ago

Hi, I'm completely new to Github. Made this account to say that I've got exactly the same problem with the double webcams, and I'm using your 0.1.9.0. Sorry, I don't know how to reopen the above

What other plugins do you have installed?

Hi, sorry new to all this. Is there a way I can export a list? Does this help:

image

Trying it just now, there was only one cam until I switched to the Pretty GCode tab and then it instantly doubled. Also I'm using UI Customiser, on a 3440x1440 screen.

MATV0 commented 2 years ago

Ah, how about this Exported list

[{"key": "uicustomizer", "name": "UI Customizer", "url": "https://github.com/LazeMSS/OctoPrint-UICustomizer"}, {"key": "touchui", "name": "TouchUI", "url": "https://github.com/BillyBlaze/OctoPrint-TouchUI"}, {"key": "terminalmessaging", "name": "Terminal Messaging", "url": "https://github.com/jeffeb3/OctoPrint-TerminalMessaging"}, {"key": "printscheduler", "name": "Print Scheduler", "url": "https://github.com/jneilliii/OctoPrint-PrintScheduler"}, {"key": "PrintJobHistory", "name": "PrintJobHistory", "url": "https://github.com/OllisGit/OctoPrint-PrintJobHistory"}, {"key": "preheat", "name": "Preheat Button", "url": "https://github.com/marian42/octoprint-preheat"}, {"key": "SpoolManager", "name": "SpoolManager Plugin", "url": "https://github.com/OllisGit/OctoPrint-SpoolManager"}, {"key": "SlicerSettingsParser", "name": "SlicerSettingsParser", "url": "https://github.com/tjjfvi/OctoPrint-SlicerSettingsParser"}, {"key": "PrintTimeGenius", "name": "PrintTimeGenius Plugin", "url": "https://github.com/eyal0/OctoPrint-PrintTimeGenius"}, {"key": "prettygcode", "name": "PrettyGCode", "url": "https://github.com/Kragrathea/OctoPrint-PrettyGCode"}, {"key": "GcodeEditor", "name": "GcodeEditor", "url": "https://github.com/ieatacid/OctoPrint-GcodeEditor"}, {"key": "extrafileinfo", "name": "ExtraFileInfo", "url": "https://github.com/larsjuhw/OctoPrint-ExtraFileInfo"}, {"key": "excluderegion", "name": "Exclude Region", "url": "https://github.com/bradcfisher/OctoPrint-ExcludeRegionPlugin"}, {"key": "camerasettings", "name": "Camera Settings", "url": "https://github.com/The-EG/OctoPrint-CameraSettings"}, {"key": "bedcooldown", "name": "Bed Cooldown", "url": "https://github.com/rfinnie/OctoPrint-BedCooldown"}, {"key": "octoeverywhere", "name": "OctoEverywhere!", "url": "http://www.OctoEverywhere.com"}, {"key": "octoapp", "name": "OctoApp", "url": "https://github.com/crysxd/OctoApp-Plugin/"}, {"key": "marlingcodedocumentation", "name": "Marlin GCode Documentation", "url": "https://github.com/costas-basdekis/MarlinGcodeDocumentation"}, {"key": "DisplayLayerProgress", "name": "DisplayLayerProgress Plugin", "url": "https://github.com/OllisGit/OctoPrint-DisplayLayerProgress"}, {"key": "consolidate_temp_control", "name": "Consolidate Temp Control", "url": "https://github.com/jneilliii/OctoPrint-ConsolidateTempControl"}, {"key": "bedlevelvisualizer", "name": "Bed Visualizer", "url": "https://github.com/jneilliii/OctoPrint-BedLevelVisualizer"}, {"key": "IFTTT", "name": "OctoPrint-IFTTT", "url": "https://github.com/tjjfvi/OctoPrint-IFTTT"}, {"key": "cancelobject", "name": "Cancel Objects", "url": "https://github.com/paukstelis/OctoPrint-Cancelobject"}]

LazeMSS commented 2 years ago

So it seems to be related to PrettyGCode - I thought i had fixed that.

LazeMSS commented 2 years ago

@MATV0 can you post screenshots? Does the problem only happen if you have PrettyGCode enabled? Can you recreate it again and again - if yes then how?

rbrian commented 1 year ago

Mine is doing the same thing, on 1.19.0. Disabling PrettyGCode fixes it. Re-enabling, it comes right back, so yes seems to be consistent and related to PGC.

LazeMSS commented 1 year ago

Basically pretty gcode seems to be dead and I can't fix it properly and OctoPrint is revamping the entire webcam stuff so I need to reimplement it all anyway.

LazeMSS commented 1 year ago

This is expected to be fix in the upcoming 0.1.9.4 release combined with the OctoPrint 1.9.0rc3 and later versions.

LazeMSS commented 1 year ago

This should now be fixed when 1.9.0 is released - closing for now - wait for 1.9.0 release or try the RC3 version. https://github.com/LazeMSS/OctoPrint-UICustomizer/releases/tag/0.1.9.4