LazeMSS / OctoPrint-UICustomizer

UI Customizer for octoprint
165 stars 18 forks source link

Custom Color in Theme #264

Closed tcon2010 closed 1 year ago

tcon2010 commented 2 years ago

I'm using the discoranged theme and simply wanted to change the orange to a new color. I looked at the inspector and saw that it was using --accent from the root of the css. Knowing that, I went to advanced and entered :root {--accent: #aaf0d1 !important;} but that did not work upon saving and refreshing. I went back to advanced and just to see what would happen I checked preview and it worked. I clicked save and all was good... until I refreshed the page. It went right back to the orange. Is there a simple way of changing colors in the theme as this doesn't seem to be working?

OctoPrint1 OctoPrint2

NOTE: I just tried to change the file name color from the dark green to the same custom color I have above. Same results: does not work upon save but does work in preview.

LazeMSS commented 2 years ago

Its basically because the order of the CSS is handled - I will look into a workaround but Im currently on a break. But the planned feature is to allow customizing the colors in the themes instead of the CSS overwrites

j-snijder commented 2 years ago

Hi, maybe a tip for use in the meanwhile.

Although octoprint warns you for conflicting plugins you could reinstall Themify ( I did :) ) and use thast together with UIcustomizer.

In my case it worked and I got back the things I altered in Themify (which I was using before I discovered UIcustomizer was preferred bij the Dev.

stayingarmed commented 1 year ago

Did anything more come of this? I would really like to customize theme colors!

tcon2010 commented 1 year ago

Did anything more come of this? I would really like to customize theme colors!

I'm not sure if anything came from the developer, but I actually ended up re-trying it myself and my custom colors started working. It's not a perfect solution; I still have a few issues in a few places that for some reason aren't obeying my CSS, but it works well enough. Makes me think the developer hasn't made an official fix yet, but it works good enough for me.

LazeMSS commented 1 year ago

I just did a full rework of the bugs and features list on another plugin. This week I will go through the UI customizer backlog

LazeMSS commented 1 year ago

I just started working on the bug backlog - this appears to be as stated by @tcon2010 by using important - even after reloading. I'm still planning on making an easier customizing where one can specify the color variables

LazeMSS commented 1 year ago

Closing this as it is working as intended - I will improve it better when "color variables" are customizable

LazeMSS commented 1 year ago

https://github.com/LazeMSS/OctoPrint-UICustomizer/issues/217