search

LazeMSS / OctoPrint-UICustomizer

UI Customizer for octoprint
165 stars 18 forks source link

Aspectratio is not respected #304

Closed fly74 closed 1 year ago

fly74 commented 1 year ago

When use of multicam plugin, only the classic webcam plugin shows the aspect correctly. From multicam it is always 4:3 even if 16:9 is in multicam configured.

https://github.com/LazeMSS/OctoPrint-UICustomizer/assets/38754941/558fd994-d447-4a7f-a525-b339141805d7

LazeMSS commented 1 year ago

Does it work then control tab? Basically is the problem isolated to only then "extra" webcam view?

fly74 commented 1 year ago

The control tab works as expected with all cams.

LazeMSS commented 1 year ago

Thanks i will look asap

LazeMSS commented 1 year ago

@fly74 please try and add this in custom css in advanced in UI Customizer plugin:

.webcam_img_container,.webcam_video_container .webcam_unrotated{
    min-height: initial !important;
}
fly74 commented 1 year ago

@LazeMSS Hey perfect. That works! Can you implement it static?

LazeMSS commented 1 year ago

Yes or maybe submit a MR to multicam plugin.

LazeMSS commented 1 year ago

Closing as this should be fixed in : https://github.com/mikedmor/OctoPrint_MultiCam/releases/tag/0.4.1