search

Lazy-Newb-Pack / Lazy-Newb-Pack-Linux

A Lazy Newb Pack for Linux
http://lazynewbpack.com/
150 stars 12 forks source link

Bashisms #32

Open Yamakaky opened 8 years ago

Yamakaky commented 8 years ago

Your shell scripts use #!/bin/sh, but it should be #!/bin/bash. On my computer, sh is a link to dash and not bash, so some bash features are not supported. http://manpages.ubuntu.com/manpages/natty/man1/checkbashisms.1.html While I'm here, you should take a look to http://redsymbol.net/articles/unofficial-bash-strict-mode/, it's really useful. And #!/usr/bin/env bash is even better.

lethosor commented 8 years ago

Which scripts do you mean? I know I've successfully tested distro_fixes.sh with dash and zsh many times. (Maybe you're using an outdated version, though - if you haven't, try grabbing the latest copy from this repo.)

Yamakaky commented 8 years ago

Sorry, the script comes from the aur package.

Yamakaky commented 8 years ago

In fact, the problem is present in the package downloadable at http://lazynewbpack.com/linux/. Maybe make a release?