search

LazyVim / starter

Starter template for LazyVim
Apache License 2.0
1.01k stars 800 forks source link

Update nvm-telescope-fzf build command #54

Closed tmysl closed 8 months ago

tmysl commented 8 months ago

Update the build command for nvm-telescope-fzf to match upstream docs and configs documented in https://github.com/nvim-telescope/telescope-fzf-native.nvim#installation docs

tmysl commented 8 months ago

More context: this is to fix this build error for nvm-telescope-fzf. this was happening on my existing install as well as a fresh install

MacOS 14.3.1 M2 Max / ARM64 NVIM v0.9.5 Build type: Release LuaJIT 2.1.1703358377

image
briandipalma commented 8 months ago

Surely all you need to do to fix the original error is install make? I'm guessing you already had cmake installed?

briandipalma commented 8 months ago

https://github.com/LazyVim/LazyVim/issues/2132

folke commented 8 months ago

fzf-native now checks for both make and cmake. We still prefer cmake.

https://github.com/LazyVim/LazyVim/commit/1c13a5c10b745f741ebbb08d3963862e9d4e307e

upstream docs also have the make as the build command, so it's not that we did that differently.

folke commented 8 months ago

Wrong repo :)

I actually removed that part from the examples, since telescope-fzf-native is now included in LazyVim by default. https://github.com/LazyVim/starter/commit/914c60ae75cdf61bf77434d2ad2fbf775efd963b