Lazza / RecuperaBit

A tool for forensic file system reconstruction.
GNU General Public License v3.0
534 stars 75 forks source link

Cleaning and filtering tools #126

Open Damrod opened 6 months ago

Lazza commented 5 months ago

Hi, thank you for opening a PR. I am not really sure what the modifications are doing, though. At first glance it seems that you are introducing multiple new features at once, which is a bit hard to grasp.

Could you please open a separate PR for each feature? If you have a related issue to refer to each PR, even better.

Finally, it seems that you are calling external processes (e.g. "grep") which is going to break Windows compatibility. Is it really necessary? Or can it be done in Python?