search

LeDDGroup / typescript-transform-paths

Transforms module resolution paths using TypeScript path mapping and/or custom paths
MIT License
465 stars 22 forks source link

feat: provide transformer for NX #155

Closed zyf0330 closed 1 year ago

zyf0330 commented 2 years ago

@nonara Hello, do you have any time to see this?

nonara commented 2 years ago

Hi @zyf0330 - I apologize for not getting to this on the weekend. I didn't realize that it was Easter, so I'm playing catch up. I am wrapping up another PR review right now and will be going over this one immediately after.

nonara commented 2 years ago

This looks pretty good. Thanks for the nice work!

I'd like to see an end-to-end test to make sure that we can track it actually working with nx. That way, in case nx ever changes anything, it will fail out and we can catch it.

Can you add a very basic test project in test/projects and make the test do a simple transform test using nx? I would likely build it with child_process.execSync.

For an example, have a look at the test/projects/extras project and test/tests/extras.test.ts test file.

zyf0330 commented 2 years ago

This looks pretty good. Thanks for the nice work!

I'd like to see an end-to-end test to make sure that we can track it actually working with nx. That way, in case nx ever changes anything, it will fail out and we can catch it.

Can you add a very basic test project in test/projects and make the test do a simple transform test using nx? I would likely build it with child_process.execSync.

For an example, have a look at the test/projects/extras project and test/tests/extras.test.ts test file.

Ok, I will try

zyf0330 commented 2 years ago

@nonara Hello, please review my e2e test. I just test declaration emit, because this is my only need.

zyf0330 commented 2 years ago

@nonara Do you have any time to review this rencently?

zyf0330 commented 2 years ago

@nonara Hello, do you have time to see this?

nonara commented 1 year ago

Hi @zyf0330 . Sorry for the delay. I've been out for a few months. I will review this shortly!

nonara commented 1 year ago

@zyf0330 First off, sorry that this took so long! I started a new development firm a year ago and ended up having no time for OSS.

Thank you for your work on this! I made a few changes to stay with the direction of the library as a whole, but it is mostly the same.

Let me know if you have any questions or comments.

nonara commented 1 year ago

Looks like I don't have write access here, so I pushed to master. Here's the commit:

zyf0330 commented 1 year ago

OK, I am glad you come back finally!