search

LeDDGroup / typescript-transform-paths

Transforms module resolution paths using TypeScript path mapping and/or custom paths
MIT License
478 stars 25 forks source link

Not working for TypeScript 4.9? #168

Closed stephenh closed 1 year ago

stephenh commented 1 year ago

I'm upgrading our codebase to 4.9.3 and noticing that paths are not being rewritten anymore.

I can put together a reproduction, but just wondering before I do that if this is a known issue/others have seen it/etc.

Thanks!

carlocorradini commented 1 year ago

@stephenh Same issue

nonara commented 1 year ago

Hi all. Unfortunately, this is an issue in 4.9. There was a regression with visitEachChild, which most transformers rely on. There is a fix ready and it's marked for review. I had hoped it would make it in to 4.9.3, but it looks like it hasn't yet.

Here are the links so you can follow the issue & PRs

bradennapier commented 1 year ago

The...wait...is...unbearable :-D good to know though, this should have been better communicated with the impact it had upon the ecosystem IMO. Glad it is already in the works - no pre-builds of 4.9.4 yet :(

DanielRosenwasser commented 1 year ago

4.9.4 is now out FWIW

samchon commented 1 year ago

typescript-transform-paths does not work on TS 4.9.4

nonara commented 1 year ago

Thanks to @DanielRosenwasser and the team for getting the fix through!

typescript-transform-paths does not work on TS 4.9.4

4.9.4 changes required changes to ttypescript and ts-patch. I investigated this and updated the methodology. The latest versions of tts and tsp now work with 4.9.4.

Having completed those updates, this library works. Simply make sure you're using the latest tts or tsp.

carlocorradini commented 1 year ago

@nonara Awesome! Can we close this?